Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [CURLRequest] getHeaderLine('Content-Type') causes InvalidArgumentException #8760

Merged
merged 3 commits into from
Apr 11, 2024
Merged

fix: [CURLRequest] getHeaderLine('Content-Type') causes InvalidArgumentException #8760

merged 3 commits into from
Apr 11, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 11, 2024 •
edited
Loading

Description
Fixes #8750

  • remove the default Response Content-Type header

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Apr 11, 2024
@kenjis kenjis mentioned this pull request Apr 11, 2024
Closed
@kenjis kenjis force-pushed the fix-CURLRequest-getHeaderLine-Content-Type branch from 5a2d1d2 to 7ec58af Compare April 11, 2024 07:42
@kenjis kenjis force-pushed the fix-CURLRequest-getHeaderLine-Content-Type branch 2 times, most recently from 17696c4 to 7a552d3 Compare April 11, 2024 09:15
@kenjis kenjis mentioned this pull request Apr 11, 2024
Merged
5 tasks
@kenjis kenjis merged commit 460466c into codeigniter4:develop Apr 11, 2024
78 of 82 checks passed
@kenjis kenjis deleted the fix-CURLRequest-getHeaderLine-Content-Type branch April 11, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [CURLRequest] Setting default Content-Type in HTTP\Response cause to multiple headers in response
2 participants
@kenjis @michalsn