Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [DebugBar] Toolbar display may be broken #8772

Merged
merged 4 commits into from
Apr 13, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 13, 2024

Description
From https://forum.codeigniter.com/showthread.php?tid=90624

If a dev changes CSS for h1, the toolbar dislpay will be broken.

Before:
Screenshot 2024-04-13 9 15 02
After:
Screenshot 2024-04-13 9 15 09

--- a/app/Views/welcome_message.php
+++ b/app/Views/welcome_message.php
@@ -34,6 +34,16 @@
         .menu {
             padding: .4rem 2rem;
         }
+        h1 {
+            font-size: 1.8em;
+            font-weight: 400;
+            font-family:'Open Sans', Sans-serif;
+            text-transform: uppercase;
+            color: #464646;
+            background-color: #f4f9eb;
+            padding: 1.4em 0 1.4em 20px;
+            margin: 0 0 1em;
+        }
         header ul {
             border-bottom: 1px solid rgba(242, 242, 242, 1);
             list-style-type: none;

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Apr 13, 2024
@kenjis kenjis merged commit 8263e08 into codeigniter4:develop Apr 13, 2024
3 checks passed
@kenjis kenjis deleted the fix-toolbar-css branch April 13, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants