Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix coding style and test-coding-standards.yml #8856

Merged
merged 3 commits into from
May 6, 2024
Merged

test: fix coding style and test-coding-standards.yml #8856

merged 3 commits into from
May 6, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented May 6, 2024 •
edited
Loading

Description
Follow-up #8746 and #8821

  • update test-coding-standards.yml
  • fix coding style for test classes

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added testing Pull requests that changes tests only github_actions Pull requests that update Github_actions code labels May 6, 2024
@kenjis kenjis merged commit 2530b23 into codeigniter4:develop May 6, 2024
36 checks passed
@kenjis kenjis deleted the fix-cs-tests branch May 6, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update Github_actions code testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @paulbalandan