Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: using phpunit 10 assertObjectHasNotProperty() and assertObjectHasProperty() #8991

Merged
merged 1 commit into from
Jun 23, 2024
Merged

refactor: using phpunit 10 assertObjectHasNotProperty() and assertObjectHasProperty() #8991

merged 1 commit into from
Jun 23, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Jun 22, 2024 •
edited
Loading

Description

using phpunit 10 assertObjectHasNotProperty() and assertObjectHasProperty(), detected by latest rector dev-main

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Member Author

Ready to merge 👍

@samsonasik
Copy link
Member Author

@paulbalandan thank you for the review, let's merge ;)

@samsonasik samsonasik merged commit 61d2742 into codeigniter4:develop Jun 23, 2024
39 checks passed
@samsonasik samsonasik deleted the refactor-phpunit-assert-object branch June 23, 2024 00:33
@kenjis kenjis added refactor Pull requests that refactor code testing Pull requests that changes tests only labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@kenjis kenjis Awaiting requested review from kenjis

Assignees
No one assigned
Labels
refactor Pull requests that refactor code testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsonasik @paulbalandan @kenjis