Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix invalid symbol '"' #9058

Merged
merged 1 commit into from
Jul 23, 2024
Merged

chore: fix invalid symbol '"' #9058

merged 1 commit into from
Jul 23, 2024

Conversation

paulbalandan
Copy link
Member

Description
This fixes a warning given by the Github Actions extension on vscode.
image

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

michalsn
michalsn approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make the same fixes to the devkit.

@paulbalandan paulbalandan mentioned this pull request Jul 22, 2024
Merged
5 tasks
@paulbalandan
Copy link
Member Author

Done, see codeigniter4/devkit#132

@michalsn
Copy link
Member

Thank you!

@paulbalandan
Copy link
Member Author

See actions/runner#753 (comment) for the proper fix.

@michalsn
Copy link
Member

Well, the syntax is not very intuitive, but it works, so 👍

@ddevsr ddevsr added the github_actions Pull requests that update Github_actions code label Jul 23, 2024
@paulbalandan paulbalandan merged commit 854c73f into codeigniter4:develop Jul 23, 2024
4 checks passed
@paulbalandan paulbalandan deleted the invalid-symbol branch July 23, 2024 12:55
@kenjis
Copy link
Member

kenjis commented Jul 24, 2024

@paulbalandan Can you update https://github.com/codeigniter4/.github ?

@MGatner
Copy link
Member

MGatner commented Aug 15, 2024

Thanks for this

kenjis added a commit to codeigniter4/.github that referenced this pull request Aug 16, 2024
@kenjis
refactor: fix warnings on VSCode
e71216e 
See codeigniter4/CodeIgniter4#9058
@kenjis kenjis mentioned this pull request Aug 16, 2024
Merged
5 tasks
@kenjis
Copy link
Member

kenjis commented Aug 16, 2024

I sent codeigniter4/.github#27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@michalsn michalsn michalsn approved these changes

@ddevsr ddevsr ddevsr approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paulbalandan @michalsn @kenjis @MGatner @ddevsr