Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix EntityTest PHPStan errors #9107

Merged
merged 4 commits into from
Aug 11, 2024
Merged

test: fix EntityTest PHPStan errors #9107

merged 4 commits into from
Aug 11, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 7, 2024 •
edited
Loading

Description
See #7731, #8732

  • add type definitions
  • fix incorrect test code

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the testing Pull requests that changes tests only label Aug 7, 2024
@kenjis kenjis mentioned this pull request Aug 7, 2024
Merged
5 tasks
@kenjis
Copy link
Member Author

kenjis commented Aug 10, 2024

Could somebody please review this?

@kenjis kenjis merged commit a5c7f77 into codeigniter4:develop Aug 11, 2024
41 checks passed
@kenjis kenjis deleted the fix-EntityTest branch August 11, 2024 10:46
@kenjis
Copy link
Member Author

kenjis commented Aug 11, 2024

@paulbalandan Thank you for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @paulbalandan