Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update preload.php #9111

Merged
merged 1 commit into from
Aug 16, 2024
Merged

fix: update preload.php #9111

merged 1 commit into from
Aug 16, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 9, 2024

Description
Fixes #9110

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Aug 9, 2024
@kenjis kenjis mentioned this pull request Aug 9, 2024
Closed
michalsn
michalsn approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine. I assume this solves the problem.

@kenjis kenjis merged commit f2e560f into codeigniter4:develop Aug 16, 2024
8 checks passed
@kenjis kenjis deleted the update-preload.php branch August 16, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Preload issues
2 participants
@kenjis @michalsn