Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add allow to cancel actions for custom cases #324

Closed

Conversation

datamweb
Copy link
Collaborator

@datamweb datamweb commented Jul 27, 2022

Hello friends.
The purpose of these PR,
Add a feature to cancel actions if there are custom cases.
This PR allows the shield to cancel actions by checking the user groups,permissions or userID.

Task checklist:

  • Add to docs
  • Edit Session::class
  • Add test

@datamweb datamweb marked this pull request as draft July 27, 2022 16:42
@datamweb
Copy link
Collaborator Author

Guys, if you agree with these PR in general, please let me know so I can complete the test as well.

@kenjis
Copy link
Member

kenjis commented Jul 27, 2022

Why do you need this feature?
Use cases?

@kenjis kenjis added the enhancement New feature or request label Jul 27, 2022
@datamweb
Copy link
Collaborator Author

  • The ability to manage resources (management of server resources for sending emails, managing financial resources for sending SMS fees)
  • Non-engagement of unfamiliar users with new topics (2fa)

Two-step login for users with low access level is not necessary in many cases and it causes financial cost or filling the ceiling of email sending limits, but it is very important for users with high access level even though it is expensive.
Therefore, by canceling actions for groups with low access level, it has helped a lot in this regard.

I believe that the actions in the shield are very useful, but they need to be changed. for example
Why don't the codes sent by actions expire?
Why is it not possible to define multiple actions for one type of action?
Why is it not possible to order the length of the sent code (usually 4 digits are used in SMS)
Why don't we have an action called Google2FA, even though it is very popular?
All these things can be implemented, but why does the shield not support them by default?

@datamweb
Copy link
Collaborator Author

I will close this issue, if a user needed this PR, we should have received a feedback by now.

@datamweb datamweb closed this Sep 13, 2022
@datamweb datamweb deleted the action-cancel-custom-cases branch September 13, 2022 05:38
@kenjis
Copy link
Member

kenjis commented Sep 14, 2022

I think if an action is to be disabled only for specific users, it is better to make it configurable for that action, rather than disabling all actions.

@datamweb
Copy link
Collaborator Author

That's right, so each user can write their own custom action if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants