Skip to content

Commit

Permalink
builtin/reflog: convert remaining unsigned char uses to object_id
Browse files Browse the repository at this point in the history
Convert the remaining uses of unsigned char [20] to struct object_id.
This conversion is needed for dwim_log.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
bk2204 authored and gitster committed Oct 16, 2017
1 parent cca5fa6 commit b8acac5
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions builtin/reflog.c
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ struct expire_reflog_policy_cb {
};

struct collected_reflog {
unsigned char sha1[20];
struct object_id oid;
char reflog[FLEX_ARRAY];
};

Expand Down Expand Up @@ -385,7 +385,7 @@ static int collect_reflog(const char *ref, const struct object_id *oid, int unus
struct collect_reflog_cb *cb = cb_data;

FLEX_ALLOC_STR(e, reflog, ref);
hashcpy(e->sha1, oid->hash);
oidcpy(&e->oid, oid);
ALLOC_GROW(cb->e, cb->nr + 1, cb->alloc);
cb->e[cb->nr++] = e;
return 0;
Expand Down Expand Up @@ -589,7 +589,7 @@ static int cmd_reflog_expire(int argc, const char **argv, const char *prefix)
for (i = 0; i < collected.nr; i++) {
struct collected_reflog *e = collected.e[i];
set_reflog_expiry_param(&cb.cmd, explicit_expiry, e->reflog);
status |= reflog_expire(e->reflog, e->sha1, flags,
status |= reflog_expire(e->reflog, e->oid.hash, flags,
reflog_expiry_prepare,
should_expire_reflog_ent,
reflog_expiry_cleanup,
Expand All @@ -601,13 +601,13 @@ static int cmd_reflog_expire(int argc, const char **argv, const char *prefix)

for (; i < argc; i++) {
char *ref;
unsigned char sha1[20];
if (!dwim_log(argv[i], strlen(argv[i]), sha1, &ref)) {
struct object_id oid;
if (!dwim_log(argv[i], strlen(argv[i]), oid.hash, &ref)) {
status |= error("%s points nowhere!", argv[i]);
continue;
}
set_reflog_expiry_param(&cb.cmd, explicit_expiry, ref);
status |= reflog_expire(ref, sha1, flags,
status |= reflog_expire(ref, oid.hash, flags,
reflog_expiry_prepare,
should_expire_reflog_ent,
reflog_expiry_cleanup,
Expand Down Expand Up @@ -659,7 +659,7 @@ static int cmd_reflog_delete(int argc, const char **argv, const char *prefix)

for ( ; i < argc; i++) {
const char *spec = strstr(argv[i], "@{");
unsigned char sha1[20];
struct object_id oid;
char *ep, *ref;
int recno;

Expand All @@ -668,7 +668,7 @@ static int cmd_reflog_delete(int argc, const char **argv, const char *prefix)
continue;
}

if (!dwim_log(argv[i], spec - argv[i], sha1, &ref)) {
if (!dwim_log(argv[i], spec - argv[i], oid.hash, &ref)) {
status |= error("no reflog for '%s'", argv[i]);
continue;
}
Expand All @@ -683,7 +683,7 @@ static int cmd_reflog_delete(int argc, const char **argv, const char *prefix)
cb.cmd.expire_total = 0;
}

status |= reflog_expire(ref, sha1, flags,
status |= reflog_expire(ref, oid.hash, flags,
reflog_expiry_prepare,
should_expire_reflog_ent,
reflog_expiry_cleanup,
Expand Down

0 comments on commit b8acac5

Please sign in to comment.