Skip to content

Commit

Permalink
cherry is built-in, do not ship git-cherry.sh
Browse files Browse the repository at this point in the history
Noticed by Rene; Makefile now has another maintainer's check
target to catch this kind of mistakes.

Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Junio C Hamano committed Nov 5, 2006
1 parent 82cc8d8 commit c74390e
Show file tree
Hide file tree
Showing 3 changed files with 39 additions and 91 deletions.
5 changes: 5 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -932,3 +932,8 @@ check-docs::
*) echo "no link: $$v";; \
esac ; \
done | sort

### Make sure built-ins do not have dups and listed in git.c
#
check-builtins::
./check-builtins.sh
34 changes: 34 additions & 0 deletions check-builtins.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
#!/bin/sh

{
cat <<\EOF
sayIt:
$(foreach b,$(BUILT_INS),echo XXX $b YYY;)
EOF
cat Makefile
} |
make -f - sayIt 2>/dev/null |
sed -n -e 's/.*XXX \(.*\) YYY.*/\1/p' |
sort |
{
bad=0
while read builtin
do
base=`expr "$builtin" : 'git-\(.*\)'`
x=`sed -ne 's/.*{ "'$base'", \(cmd_[^, ]*\).*/'$base' \1/p' git.c`
if test -z "$x"
then
echo "$base is builtin but not listed in git.c command list"
bad=1
fi
for sfx in sh perl py
do
if test -f "$builtin.$sfx"
then
echo "$base is builtin but $builtin.$sfx still exists"
bad=1
fi
done
done
exit $bad
}
91 changes: 0 additions & 91 deletions git-cherry.sh

This file was deleted.

0 comments on commit c74390e

Please sign in to comment.