Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix workspace actions options #13572

Merged
merged 4 commits into from
Jun 17, 2024
Merged

fix: fix workspace actions options #13572

merged 4 commits into from
Jun 17, 2024
+138 −102

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Jun 13, 2024 •
edited

Simplify the code a bit to prevent bad states, and add additional stories.

@aslilac aslilac requested review from BrunoQuaresma, kylecarbs and a team June 13, 2024 17:31
BrunoQuaresma
BrunoQuaresma reviewed Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is an improvement but I'm not sure if our tests are in place to avoid confusion and unwanted changes in the future.

@aslilac
Copy link
Member Author

aslilac commented Jun 14, 2024

I think there should be a story for every code path now.

BrunoQuaresma
BrunoQuaresma approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. I left two comments in Storybook for your consideration.

@aslilac aslilac merged commit 07cd9ac into main Jun 17, 2024
34 of 36 checks passed
@aslilac aslilac deleted the fix-workspace-actions branch June 17, 2024 16:24
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aslilac @BrunoQuaresma