Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork button doesn't show feedback while forking #844

Closed
ValentinH opened this issue May 16, 2018 · 2 comments
Closed

Fork button doesn't show feedback while forking #844

ValentinH opened this issue May 16, 2018 · 2 comments

Comments

@ValentinH
Copy link
Contributor

馃悰 bug report

Description of the problem

Today at React-Europe, we used CodeSandbox (again) and had to fork a sandbox. However, the wifi was pretty slow and thus the fork was not immediate. Thus, it feels like it wasn't working so I clicked again (many times ^^). Then the sandbox reloaded several times with each time a new fork.

Suggestion

Display a loader while forking or disable the button.

@lbogdan
Copy link
Contributor

lbogdan commented Mar 28, 2019

THIS!

@ValentinH
Copy link
Contributor Author

I actually forgot about this issue. Can I work on it?

ValentinH pushed a commit to ValentinH/codesandbox-client that referenced this issue Mar 28, 2019
Fixes codesandbox#844.

This is a first fix. I'd like to work on a better feedback, maybe a circular loader inside the button. What do you think?
CompuIves pushed a commit that referenced this issue Mar 29, 2019
* Disable fork button while forking

Fixes #844.

This is a first fix. I'd like to work on a better feedback, maybe a circular loader inside the button. What do you think?

* Change the text to "Forking" while forking

* Also disabled the "Fork Sandbox" button in Workspace More

* Forking...

* Forking... 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants