Add Expand/Collapse to Tests #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wooow, this is one of the most polished PRs I've seen. Big thanks @dv297! This looks really good, also fits in the existing style. Code looks good as well, so we can merge! Thanks again, great PR! |
SaraVieira
pushed a commit
to SaraVieira/codesandbox-client
that referenced
this pull request
Nov 22, 2018
* Add @dv297 as a contributor * Add expand/collapse for TestElement
SaraVieira
pushed a commit
to SaraVieira/codesandbox-client
that referenced
this pull request
Nov 23, 2018
* Add @dv297 as a contributor * Add expand/collapse for TestElement
This was referenced Feb 11, 2022
This was referenced Nov 5, 2022
This was referenced Dec 25, 2022
This was referenced Nov 25, 2023
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
What kind of change does this PR introduce?
Add a new icon to the TestElement that allows you to expand and collapse the expectations underneath a test file.
What is the current behavior?
Does not exist, new feature
What is the new behavior?
Allows you to expand and collapse the tests
Expand Screenshot
Collapse Screenshot
Interaction GIF
Checklist:
First PR into Code Sandbox =) There was no issue logged, I just felt like this was a quality of life improvement I could make. I couldn't find any test files specific to Tests.js or TestElement/index.js, it looked like you only did snapshot testing for "atom"-level components. Please correct me if I'm mistaken! I'm also not aware of any documentation that needs to be added if there needs to be!