feat(template): add Adonis template #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great!! I added one comment, after adding that it's good to go! |
|
Ready to be merged on my side! 馃憤 |
|
Thank you for this! |
|
@allcontributors[bot] add @RomainLanz for code |
|
I've put up a pull request to add @RomainLanz! 馃帀 |
CompuIves
pushed a commit
that referenced
this pull request
Apr 16, 2019
Adds @RomainLanz as a contributor for code. This was requested by CompuIves [in this comment](#1753 (comment))
|
Hey! I deployed this today, but I noticed an error with missing |
|
I added a PR for this: https://github.com/adonisjs/adonis-starter-codesandbox/pull/1 |
|
I will message him on twitter :) |
|
Hey! 馃憢 Should be all good by now. |
|
All perfect now! Thanks :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all! 馃憢
This PR add AdonisJs as a template.
When I tested locally the code I wasn't able to load my template as server side container. It took the
create-react-apptemplate by default.I don't know if I need to add a
sandbox.config.jsonto the root of our repository or it's normal and will be fixed when theimportersPR will be merged?Regarding the template definition, I have not added
popularormainproperty. I believe this can be added later if you saw it's a popular template.Importers PR: codesandbox/codesandbox-importers#36