Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added enhancement per isssue #470. #482

Merged
merged 2 commits into from
Jan 29, 2018
Merged

added enhancement per isssue #470. #482

merged 2 commits into from
Jan 29, 2018

Conversation

Jakhotiya
Copy link
Contributor

Now latest dependencies will display version number along side label latest like:
package latest (semver version)

modified:   packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/VersionEntry.js

this is a enhancement per #470

Checklist:

  • Documentation "N/A"
  • Tests "N/A"
  • Ready to be merged
  • Added myself to contributors table

…ay version number along side label latest like package latest (semver version)

	modified:   packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/VersionEntry.js
@CompuIves
Copy link
Member

Ahh perfect! Thank you very much @Jakhotiya. The only thing left is adding yourself to the contributors table (npm run add) and fixing the lint errors. Then it's ready for merge 😄

@Jakhotiya
Copy link
Contributor Author

Fixed linting errors. Before merging can you review my code and give me some feedback on what can be improved?

Copy link
Member

@CompuIves CompuIves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me! Thanks for the contribution, merging now 😄

@CompuIves CompuIves merged commit 598e82f into codesandbox:master Jan 29, 2018
@vvo
Copy link

vvo commented Feb 2, 2018

Thanks a lot @Jakhotiya :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants