fix(signout): Fixing UI updates after sign out #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if UserMenu should render in Navigation
|
Ha @arthurdenner, that's perfect, I think you're right with that! I'll merge this in and will test it on staging before deploy, thanks for the contribution 😄. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR tries to
reallyfix #852.What is the current behavior?
After signing out, the UI breaks.
What is the new behavior?
After failing in fixing this in #891, I investigated this problem and as weird as it sounds, using the
store.isLoggedIninstead ofstore.userto compute if theUserMenushould render in theNavigationcomponent fixes the problem. Please, confirm this before deploying in case I'm wrong again. 🙈Checklist: