fix: style prop no longer passed to React.Fragment #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c9418a1:
|
danilowoz
reviewed
Oct 4, 2022
| @@ -93,6 +92,13 @@ export const Sandpack: SandpackInternal = (props) => { | |||
| height: props.options?.editorHeight, // use the original editor height | |||
| }; | |||
|
|
|||
| const RightColumn: React.FC<{ children: React.ReactNode }> = ({ children }) => | |||
There was a problem hiding this comment.
Hummm... I'm afraid that this will remount everything and its children on every render.
What about conditionally passing the props to the RightColumn? Something like this:
const rightColumnProps = useMemo(() => hasRightColumn ? { style } : {}, [hasRightColumn])
<RightColumn {...rightColumnProps}>There was a problem hiding this comment.
Wow yep, I wasn't thinking, haha. Updated 👍
danilowoz
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this pull request introduce?
Bug fix
What is the current behavior?
Currently getting this error when using Sandpack React:
I traced back the error back to this point in the code.
What is the new behavior?
Don't apply the
styleprop toReact.FragmentWhat steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
It seemed fine in CodeSandbox projects, but I have done no more testing. Please check everything works!