Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: style prop no longer passed to React.Fragment #601

Merged
merged 2 commits into from
Oct 4, 2022
Merged

fix: style prop no longer passed to React.Fragment #601

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
090a5ae
fix: style prop no longer passed to React.Fragment
CTNicholas Oct 2, 2022
c9418a1
fix: Better performance
CTNicholas Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion sandpack-react/src/presets/Sandpack.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,11 @@ export const Sandpack: SandpackInternal = (props) => {
height: props.options?.editorHeight, // use the original editor height
};

const rightColumnProps = React.useMemo(
() => (hasRightColumn ? { style: rightColumnStyle } : {}),
[hasRightColumn]
);

/* eslint-disable-next-line @typescript-eslint/no-non-null-assertion */
const templateFiles = SANDBOX_TEMPLATES[props.template!] ?? {};
const mode = "mode" in templateFiles ? templateFiles.mode : "preview";
Expand Down Expand Up @@ -128,7 +133,7 @@ export const Sandpack: SandpackInternal = (props) => {
/>

{/* @ts-ignore */}
<RightColumn style={rightColumnStyle}>
<RightColumn {...rightColumnProps}>
{mode === "preview" && (
<SandpackPreview
actionsChildren={actionsChildren}
Expand Down