Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade Node.js version #1029

Merged
merged 10 commits into from
Nov 15, 2023
Prev Previous commit
feat: Added ts task to .codesandbox/tasks.json
Added 'ts' task with command 'yarn typecheck' to .codesandbox/tasks.json
  • Loading branch information
danilowoz committed Nov 15, 2023
commit 45df3e35bf774de53aeb5af329b1523f7fdbed79
9 changes: 5 additions & 4 deletions .codesandbox/tasks.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@
"command": "yarn build",
"runAtStart": true
},
"ts": {
"name": "Typecheck",
"command": "yarn typecheck"
},
"build:client": {
"name": "Build: client",
"command": "yarn workspace @codesandbox/sandpack-client build",
Expand Down Expand Up @@ -71,10 +75,7 @@
"name": "Install",
"command": "yarn install",
"restartOn": {
"files": [
"yarn.lock",
"**/package.json"
],
"files": ["yarn.lock", "**/package.json"],
"branch": false,
"resume": false
}
Expand Down
4 changes: 2 additions & 2 deletions sandpack-react/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ export type SandpackThemeProp =
*/

export type TemplateFiles<Name extends SandpackPredefinedTemplate> =
keyof (typeof SANDBOX_TEMPLATES)[Name]["files"];
keyof typeof SANDBOX_TEMPLATES[Name]["files"];

export interface SandpackInternal {
<
Expand Down Expand Up @@ -618,7 +618,7 @@ export type SandpackStatus =
export type EditorState = "pristine" | "dirty";

export interface SandboxTemplate {
files: SandpackFiles;
files: SandpackBundlerFiles;
dependencies: Record<string, string>;
devDependencies?: Record<string, string>;
entry?: string;
Expand Down
2 changes: 1 addition & 1 deletion sandpack-react/src/utils/sandpackUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export const getSandpackStateFromProps = (
});

// visibleFiles and activeFile override the setup flags
let visibleFiles = normalizePath(props.options?.visibleFiles ?? []);
let visibleFiles: string[] = normalizePath(props.options?.visibleFiles ?? []);
let activeFile = props.options?.activeFile
? resolveFile(props.options?.activeFile, projectSetup.files)
: undefined;
Expand Down
Loading