win_dns_client - fix bug in devel and added tests (ansible#58971)

* win_dns_client - fix bug in devel and added tests * Fix sanity issue
codewc · Jul 11, 2019 · bcc23e7 · bcc23e7
1 parent 6aad3a6
commit bcc23e7
Show file tree

Hide file tree

Showing 5 changed files with 752 additions and 2 deletions.
diff --git a/lib/ansible/modules/windows/win_dns_client.ps1 b/lib/ansible/modules/windows/win_dns_client.ps1
@@ -96,11 +96,12 @@ Function Set-DnsClientServerAddressLegacy {
     $adapter_config = Get-CIMInstance Win32_NetworkAdapterConfiguration -Filter "Index=$idx"
 
     If($ResetServerAddresses) {
-        $res = $adapter_config.SetDNSServerSearchOrder()
+        $arguments = @{}
     }
     Else {
-        $res = $adapter_config.SetDNSServerSearchOrder($ServerAddresses)
+        $arguments = @{ DNSServerSearchOrder = $ServerAddresses }
     }
+    $res = Invoke-CimMethod -InputObject $adapter_config -MethodName SetDNSServerSearchOrder -Arguments $arguments
 
     If($res.ReturnValue -ne 0) {
         throw "Set-DnsClientServerAddressLegacy: Error calling SetDNSServerSearchOrder, code $($res.ReturnValue))"

diff --git a/test/integration/targets/win_dns_client/aliases b/test/integration/targets/win_dns_client/aliases
@@ -0,0 +1 @@
+shippable/windows/group2