Skip to content

Commit

Permalink
Coding guidelines were not PEP8 compliant :-) (ansible#25589)
Browse files Browse the repository at this point in the history
  • Loading branch information
dagwieers authored and gundalow committed Jun 13, 2017
1 parent e017bf9 commit f380fd8
Showing 1 changed file with 10 additions and 14 deletions.
24 changes: 10 additions & 14 deletions CODING_GUIDELINES.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,21 +101,21 @@ Use the dict constructor where possible when allocating dictionaries:

# this:
foo = dict(
a = 12,
b = 34
a=12,
b=34,
)

Line up variables
Do not line up variables

# not this
a = 12
a = 12
foosball = 34
xyz = 'dog'
xyz = 'dog'

# this
a = 12
a = 12
foosball = 34
xyz = 'dog'
xyz = 'dog'

Don't use line continuations:

Expand All @@ -131,13 +131,13 @@ Don't use line continuations:
Spacing:

# no
x=[1,2,3]
x = [1,2,3]

# no
x = [1,2,3]
x = [ 1, 2, 3 ]

# yes
x = [ 1, 2, 3 ]
x = [1, 2, 3]

Spacing continued:

Expand Down Expand Up @@ -314,7 +314,3 @@ This was not meant to be a scary document, so we hope it wasn't, but we also hop
If you have questions about this document, please ask on the ansible-devel mailing list.

Thank you!




0 comments on commit f380fd8

Please sign in to comment.