Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProtoJSON safely encode JSON to ASCII-8BIT (String#b) #264

Merged
merged 1 commit into from
Oct 11, 2023
Merged

ProtoJSON safely encode JSON to ASCII-8BIT (String#b) #264

merged 1 commit into from
Oct 11, 2023

Conversation

stuppy
Copy link
Contributor

@stuppy stuppy commented Sep 6, 2023

ProtoJSON data bytes support w/ String#b

#263

JSON payload converter does the same here.

@bobbytables
Copy link

bobbytables commented Oct 10, 2023 •
edited
Loading

We're hitting this as well, any way to get this merged and tagged in a release? We can help test if valuable.

@stuppy
Copy link
Contributor Author

stuppy commented Oct 11, 2023

@DeRauk @jeffschoner Any chance you can review? Thank you!

@DeRauk DeRauk merged commit 0540942 into coinbase:master Oct 11, 2023
2 checks passed
@DeRauk
Copy link
Contributor

DeRauk commented Oct 11, 2023

@stuppy merged, thank you!

cc @bobbytables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeRauk DeRauk DeRauk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stuppy @bobbytables @DeRauk