Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow start delay option #294

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

santiagodoldan
Copy link
Contributor

No description provided.

@jeffschoner
Copy link
Contributor

Extending the GRPC connection is not sufficient to get this working. You'll also need to define options for the method in the client and map them onto the connection at https://github.com/coinbase/temporal-ruby/blob/master/lib/temporal/client.rb#L43

@santiagodoldan
Copy link
Contributor Author

Sounds good, I'll apply changes today, thanks @jeffschoner

@bdchauvette
Copy link

Hi @santiagodoldan!

I'm doing some work right now that would also benefit from this feature. Let me know if you'd like a hand making the changes to get this PR over the line!

@santiagodoldan
Copy link
Contributor Author

I'll work on this during the weekend 💯

@doctomarculescu
Copy link

Hi santiagodoldan,

I am very interested in this future for a PoC my company is conducting on temporal. Did you have a chance to get back to the PR or is there any way I could help on this ?

Many thanks,
Andrei

@santiagodoldan
Copy link
Contributor Author

Sorry for the delay, I was super busy, thanks @jeffschoner for the help, I tested locally and it's working great, I was able to start workflows with different delays, here a screenshot of temporal dashboard

image

@santiagodoldan
Copy link
Contributor Author

@DeRauk can you take a look at this one?

@santiagodoldan
Copy link
Contributor Author

Can I get some feedback here? I'd love to get this one in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants