Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying arbitrary attributes on the builder struct #237

Merged
merged 15 commits into from
Mar 15, 2022
Merged

Allow specifying arbitrary attributes on the builder struct #237

merged 15 commits into from
Mar 15, 2022

Commits on Mar 15, 2022

  1. Field: Distinguish field from setter attributes 

    Right now we just clone and drain Field::attrs.  But these values are
going to be distinct in a moment.
    @ijackson
    ijackson committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    7975874 View commit details
    Browse the repository at this point in the history

  2. Support builder_field_attrs(...)

    @ijackson
    ijackson committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    748a375 View commit details
    Browse the repository at this point in the history

  3. Test that builder_field_attrs(...) is honoured

    @ijackson
    ijackson committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    b408855 View commit details
    Browse the repository at this point in the history

  4. Document builder_field_attrs(...) 

    This is hard to demonstrate without importing some other crate whose
attributes can be used.  Choose serde.
    @ijackson
    ijackson committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    576ab2a View commit details
    Browse the repository at this point in the history

  5. Add JSON to builder_field_attrs test 

    This makes the example better and the test more thorough.
    @ijackson
    ijackson committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    f4fd599 View commit details
    Browse the repository at this point in the history

  6. Support builder_setter_attr() 

    S
    @ijackson
    ijackson committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    6d3331d View commit details
    Browse the repository at this point in the history

  7. Test builder_setter_attr(...)

    @ijackson
    ijackson committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    ee9bd08 View commit details
    Browse the repository at this point in the history

  8. Document builder_setter_attrs 

    I couldn't think of a good example.
    @ijackson
    ijackson committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    d49e469 View commit details
    Browse the repository at this point in the history

  9. builder_field_attr, builder_setter_attr: switch to ( ) syntx 

    As per
  colin-kiegel#237 (comment)
    @ijackson
    ijackson committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    f207dba View commit details
    Browse the repository at this point in the history

  10. Remove leftover foolish comments about foolish repr attributes

    @ijackson
    ijackson committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    c87f821 View commit details
    Browse the repository at this point in the history

  11. Rename builder_field_attr and builder_setter_attr 

    They were plural.  Renaming only in this commit.
    @ijackson
    ijackson committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    a8e5598 View commit details
    Browse the repository at this point in the history

  12. Remove spurious Vec from unnested attributes

    @ijackson
    ijackson committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    0fc1886 View commit details
    Browse the repository at this point in the history

  13. builder_setter_attr: Move docs back, fix mismerge 

    git-rebase applied this hunk to the wrong part of the file.
    @ijackson
    ijackson committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    6f6b601 View commit details
    Browse the repository at this point in the history

  14. attributes: Fix up an error messages and an comment

    @ijackson
    ijackson committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    77dc5fe View commit details
    Browse the repository at this point in the history

  15. Run rustfmt

    @ijackson
    ijackson committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    22b4d9a View commit details
    Browse the repository at this point in the history