-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add restricted visibility support to builders, build methods, setters, and fields #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TedDriggs
commented
Apr 6, 2022
* Use Cow<syn::Visibility> to avoid unnecessary cloning * Make as_expressed_vis return a Result * Add Visibility::explicit
TedDriggs
commented
Apr 13, 2022
@indietyp want to take a look at this PR? |
TedDriggs
changed the title
Change FlagVisibility to support explicit visibilities
Add restricted visibility support to builders, build methods, setters, and fields
Apr 13, 2022
indietyp
approved these changes
Apr 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
@ijackson can I merge this without breaking your work on custom field types too badly? |
Please go ahead, I can fix up conflicts. I don't want to block others' work. |
Fields, setters, build methods, and builder structs can now be marked as public, private, or have a restricted visibility with vis = "...". Fixes #246
This defers conflict checking until the end so that every level can participate, and errors are consistently generated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be updated for #246 soon.