Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init docker support (Nvidia and AMD) #190

Closed
wants to merge 20 commits into from
Closed

Init docker support (Nvidia and AMD) #190

wants to merge 20 commits into from

Conversation

LEv145
Copy link

@LEv145 LEv145 commented Mar 20, 2023

Minimum initial docker-compose to run
изображение

#188

How to use:

docker compose --profile cpu up  # CPU
docker compose --profile nvidia up  # Nvidia with https://download.pytorch.org/whl/cu117 
docker compose --profile amd up  # AMD with https://download.pytorch.org/whl/rocm5.4.2
docker compose --profile amd6600 up  # like amd profile, but with HSA_OVERRIDE_GFX_VERSION=10.3.0

Add volumes
Add `output` volume
Add `input` into `volumes`
Add `custom_nodes` into `volumes`
@paulo-coronado
Copy link

Hey @LEv145! Thanks for sharing it! I am also working with Comfy + Docker hosted on Runpod's Serverless GPU, but I am getting NVIDIA erros. I can't link my GPU with the containers... 😢

@LEv145
Copy link
Author

LEv145 commented Mar 24, 2023

Hey @LEv145! Thanks for sharing it! I am also working with Comfy + Docker hosted on Runpod's Serverless GPU, but I am getting NVIDIA erros. I can't link my GPU with the containers... cry

I'm happy to share
On my graphics card, docker-compose works stably without errors

Probably a problem in nvidia-docker, I hope you fix it

@comfyanonymous
Copy link
Owner

Unfortunately I don't have a nvidia card so I can't test this.

@LEv145
Copy link
Author

LEv145 commented Mar 27, 2023

Unfortunately I don't have a nvidia card so I can't test this.

I have nvidia 2600 super working on my card, it should work on any card from nvidia, because I use nvidia-docker

I can add a version without gpu to docker

@LEv145 LEv145 changed the title Init docker support (Nvidia only) Init docker support (Nvidia and AMD) Mar 27, 2023
@LEv145
Copy link
Author

LEv145 commented Mar 27, 2023

I'm edited docker architecture

Usage:

cd docker
docker compose --profile cpu up  # CPU
docker compose --profile nvidia up  # Nvidia with https://download.pytorch.org/whl/cu117 
docker compose --profile amd up  # AMD with https://download.pytorch.org/whl/rocm5.4.2
docker compose --profile amd6600 up  # like amd profile, but with HSA_OVERRIDE_GFX_VERSION=10.3.0

@paulo-coronado
Copy link

paulo-coronado commented Mar 27, 2023

Hello, @LEv145! Thanks for adding Docker support! Could you please add me on Discord (@pcoronado#4338)? I am new in docker compose and I have some questions about your fork :)

LEv145 and others added 3 commits April 20, 2023 21:19
Move docker file to root path (most common use case)
Use local volumes
Fix after git sync
@kwaa
Copy link
Contributor

kwaa commented Apr 24, 2023

If merged, I would be interested in adding Intel Arc Graphics support.

@LEv145
Copy link
Author

LEv145 commented Apr 28, 2023

Good stuff:
AbdBarho/stable-diffusion-webui-docker#384

@kwaa
Copy link
Contributor

kwaa commented Apr 28, 2023

Good stuff: AbdBarho/stable-diffusion-webui-docker#384

Unfortunately, this repo only seems to support NVIDIA graphics cards.

@LEv145
Copy link
Author

LEv145 commented Jun 1, 2023

@LEv145 LEv145 closed this by deleting the head repository Nov 18, 2023
mid-dev-media pushed a commit to mid-dev-media/ComfyUI that referenced this pull request Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants