LogReader: print number of missing rlogs #32830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
|
i wanted to do optimization to remove useless counting of qlogs in return statement, but we can leave that as it is, to minimize changes. |
sshane
reviewed
Jun 27, 2024
tools/lib/logreader.py
Outdated
Comment on lines
93
to
98
| def count_missing_rlogs(rlog_paths: LogPaths, valid_file: ValidFileCallable) -> int: | ||
| missing_count = 0 | ||
| for rlog in rlog_paths: | ||
| if rlog is None or not valid_file(rlog): | ||
| missing_count += 1 | ||
| return missing_count |
There was a problem hiding this comment.
cached the result so we don't take 2x longer
|
This PR is now a slight speed up due to not checking qlogs upfront |
sshane
changed the title
|
thanks for getting this started! |
0312birdzhang
pushed a commit
to orapilot/opilot
that referenced
this pull request
Jun 27, 2024
* count rlogs * minimization changes * cache to avoid duplicate checks * no real point in checking qlogs to just show the warning --------- Co-authored-by: Shane Smiskol <shane@smiskol.com>
Edison-CBS
pushed a commit
to Edison-CBS/openpilot
that referenced
this pull request
Sep 15, 2024
* count rlogs * minimization changes * cache to avoid duplicate checks * no real point in checking qlogs to just show the warning --------- Co-authored-by: Shane Smiskol <shane@smiskol.com> old-commit-hash: 504dd45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#32799