Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: refactor driver monitor updating and rendering into DriverMonitorRenderer class #33375

Merged
merged 3 commits into from
Sep 1, 2024
Merged

ui: refactor driver monitor updating and rendering into DriverMonitorRenderer class #33375

merged 3 commits into from
Sep 1, 2024

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented Aug 26, 2024

No description provided.

@github-actions github-actions bot added the ui label Aug 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 26, 2024 •
edited
Loading

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@deanlee deanlee mentioned this pull request Aug 26, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 26, 2024 •
edited
Loading

UI Screenshots

@deanlee deanlee force-pushed the ui_refactor_driver_monitor branch 4 times, most recently from 3ad92fa to f730e27 Compare August 31, 2024 05:01
@deanlee deanlee marked this pull request as draft August 31, 2024 16:11
@deanlee deanlee force-pushed the ui_refactor_driver_monitor branch 4 times, most recently from 031e136 to 782db6d Compare September 1, 2024 06:27
@deanlee deanlee marked this pull request as ready for review September 1, 2024 08:37
adeebshihadeh
adeebshihadeh requested changes Sep 1, 2024
View reviewed changes
Copy link
Contributor

@adeebshihadeh adeebshihadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from filename

selfdrive/ui/SConscript Outdated Show resolved Hide resolved
@adeebshihadeh adeebshihadeh marked this pull request as draft September 1, 2024 17:52
@deanlee deanlee marked this pull request as ready for review September 1, 2024 18:18
@adeebshihadeh adeebshihadeh merged commit af80a13 into commaai:master Sep 1, 2024
18 checks passed
@deanlee deanlee deleted the ui_refactor_driver_monitor branch September 1, 2024 19:16
fredyshox pushed a commit that referenced this pull request Sep 4, 2024
@deanlee
ui: refactor driver monitor updating and rendering into `DriverMonito…
43025c2 
…rRenderer` class (#33375)

* Refactor Driver Monitor Updating and Rendering

add comments

* rebase master

* rename dmon to driver_monitoring
old-commit-hash: af80a13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adeebshihadeh adeebshihadeh adeebshihadeh requested changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deanlee @adeebshihadeh