Skip to content

Commit

Permalink
Revert "iso-tp: more sanity checks (#1487)"
Browse files Browse the repository at this point in the history
This reverts commit 01db9e4.
  • Loading branch information
sshane committed Aug 29, 2023
1 parent 8c9f9d0 commit a2b5daf
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions python/uds.py
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,6 @@ def _isotp_rx_next(self, rx_data: bytes) -> ISOTP_FRAME_TYPE:
# assert len(rx_data) == self.max_len, f"isotp - rx: invalid CAN frame length: {len(rx_data)}"

if rx_data[0] >> 4 == ISOTP_FRAME_TYPE.SINGLE:
assert not self.rx_done, "isotp - rx: unexpected single frame"
self.rx_len = rx_data[0] & 0x0F
assert self.rx_len < self.max_len, f"isotp - rx: invalid single frame length: {self.rx_len}"
self.rx_dat = rx_data[1:1 + self.rx_len]
Expand All @@ -484,7 +483,6 @@ def _isotp_rx_next(self, rx_data: bytes) -> ISOTP_FRAME_TYPE:
return ISOTP_FRAME_TYPE.SINGLE

elif rx_data[0] >> 4 == ISOTP_FRAME_TYPE.FIRST:
assert self.rx_dat == b"", "isotp - rx: first frame with data already received"
self.rx_len = ((rx_data[0] & 0x0F) << 8) + rx_data[1]
assert self.max_len <= self.rx_len, f"isotp - rx: invalid first frame length: {self.rx_len}"
self.rx_dat = rx_data[2:]
Expand Down

0 comments on commit a2b5daf

Please sign in to comment.