Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safety: 2021+ Rav4 Prime #1841

Closed
wants to merge 11 commits into from
Closed

Safety: 2021+ Rav4 Prime #1841

wants to merge 11 commits into from

Conversation

pd0wm
Copy link
Contributor

@pd0wm pd0wm commented Jan 29, 2024

TODO:

  • Add unit tests for new flags
  • Check if any of the new messages have checksum that can be verified by the panda
  • Ensure blocking 0x131 from camera doesn't affect any existing Toyotas (or just put behind flag).

board/safety/safety_toyota.h Outdated Show resolved Hide resolved
board/safety/safety_toyota.h Outdated Show resolved Hide resolved
jyoung8607 added a commit to jyoung8607/panda that referenced this pull request Sep 26, 2024
@jyoung8607 jyoung8607 mentioned this pull request Sep 26, 2024
5 tasks
@jyoung8607
Copy link
Collaborator

Carrying forward in #2042.

@jyoung8607 jyoung8607 closed this Sep 26, 2024
adeebshihadeh pushed a commit that referenced this pull request Oct 4, 2024
* from @pd0wm #1841

* diff reduction: won't need the flag rename

* run tests with new DBC and new gas/brake messages

* toyota_secoc_car to global

* consolidate alt_brake_101

* consolidate alt_pcm_cruise_176

* consolidate alt_gas_pedal_116

* don't allow transmit/forward for 0x131 unless SecOC

* cleanup and todo

* diff reduction

* reorder by usage frequency

* test for no LTA actuation

* bump opendbc commit ref in Dockerfile

* gate SecOC variant on ALLOW_DEBUG

* tweak gating for MISRA

* mutation test hates lta_angle surviving various changes

* common rx checks styling

* don't allow short version of 0x2E5 for SecOC mode

* whitespace diff reduction

* secoc_car -> secoc

* fix comment typo

* retry CI

* missed a couple secoc_car -> secoc

* one big secoc/not-secoc block

* genuinely useful MISRA warning

* test both STEERING_LTA and STEERING_LTA_2

* comment labeling for STEERING_LTA_2 signals

* Update board/safety/safety_toyota.h

Co-authored-by: Shane Smiskol <shane@smiskol.com>

* STEERING_LTA and STEERING_LTA_2 consistency

* update gas/brake/cruise signal annotations

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants