Allow callers to omit event_type when event data is a struct
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @OleMchls. |
slashdotdash
changed the title
event_type when event data is a struct
slashdotdash
added a commit
that referenced
this pull request
May 28, 2018
Add Ole Michaelis to contributors section in README.
slashdotdash
added a commit
that referenced
this pull request
May 29, 2018
Add Ole Michaelis to contributors section in README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #116
event_typeis required for each event to be passed into eventstore even though it could be detected within the app. This is the technical implementation to add the possibility to omit this argument when a struct is passed.A possible second step that is not part of this PR could be to refactor/rewrite the documentation to remove the
event_typefrom the examples and thus invert the regular flow to omit it, and only pass it when needed.fixes #116