-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscription concurrency #134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slashdotdash
force-pushed
the
feature/concurrency
branch
2 times, most recently
from
September 2, 2018 22:07
3b8d388
to
405c6bd
Compare
👍 |
slashdotdash
force-pushed
the
feature/concurrency
branch
from
September 17, 2018 09:59
53c1b86
to
4690ca6
Compare
Persist last seen event to storage ordered by event id, irrespective of the order of acknowledgements received from possibly many subscribers.
Use round robbin balancing to distribute events amongst subscribers.
Subscription test case used to test single and all streams subscriptions.
Separate deleting an existing subscription from unsubscribe as subscriptions may now have multiple subscribers.
slashdotdash
force-pushed
the
feature/concurrency
branch
from
September 17, 2018 10:04
4690ca6
to
a06bc3e
Compare
slashdotdash
force-pushed
the
feature/concurrency
branch
from
September 17, 2018 21:32
466eecf
to
d971424
Compare
Include #134 in CHANGELOG.
Due to not waiting for subscriber process to terminate in test.
Heroic effort! This is going to bring some exciting capabilities to commanded. |
renanlage
pushed a commit
to stone-payments/eventstore
that referenced
this pull request
Oct 19, 2018
Include commanded#134 in CHANGELOG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow multiple subscribers to connect to a single subscription, allowing concurrent event processing and load balancing between all connected subscriber processes.
Connecting more than one subscriber to a subscription will mean that event handling order is no longer guaranteed since events will be processed concurrently. However you can provide a
partition_by
function to return a partition key from an event. This will guarantee events for the same key will be handled in order. You might use an aggregate's identity as the partition key to have events for each aggregate instance ordered.Example usage
See the Subscription concurrency section in the subscription guide for more detail.
Fixes #124.