Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #72

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Fix typo #72

merged 2 commits into from
Sep 4, 2024

Conversation

matthyk
Copy link
Contributor

@matthyk matthyk commented Sep 1, 2024

Just a small typo fix

@shadowspawn shadowspawn changed the base branch from main to develop September 2, 2024 08:58
@shadowspawn shadowspawn changed the base branch from develop to release/13.x September 2, 2024 09:01
shadowspawn
shadowspawn approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@shadowspawn shadowspawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shadowspawn
Copy link
Contributor

To avoid breaking anyone in a minor update, I think this needs to land in a major version. (Despite being a typo!)

@shadowspawn shadowspawn merged commit ba74762 into commander-js:release/13.x Sep 4, 2024
9 checks passed
@shadowspawn shadowspawn added the pending release On a branch for eventual release, but not yet merged to main. label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abetomo abetomo abetomo approved these changes

@shadowspawn shadowspawn shadowspawn approved these changes

Assignees
No one assigned
Labels
pending release On a branch for eventual release, but not yet merged to main. semver:major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthyk @shadowspawn @abetomo