Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-cz doesn't finish, doesn't return the prompt #563

Closed
meszaros-lajos-gyorgy opened this issue Sep 9, 2018 · 11 comments
Closed

git-cz doesn't finish, doesn't return the prompt #563

meszaros-lajos-gyorgy opened this issue Sep 9, 2018 · 11 comments

Comments

@meszaros-lajos-gyorgy
Copy link

meszaros-lajos-gyorgy commented Sep 9, 2018

Hi!

Since one of the recent updates (sadly I don't know which one exactly) when I run git-cz, the commit is created as expected, pre-commit hook also runs - if there is any -, but commitizen never exits after it's done. I also tried git-cz --retry and it works fine, there is no issue there.

There was a ticket addressing the same issue, but it's creator claims, that he solved the issue by updating his node version: #545

I'm using node 10.10.0, npm 6.4.1, windows 7, commitizen 2.10.1 and cz-convencional-changelog 2.1.0.

I've tried using it through visual studio code's integrated terminal and windows command line.

There are no error messages, so this is how far I got.

@meszaros-lajos-gyorgy
Copy link
Author

Since git-cz --retry doesn't display options and it works fine, I have a hunch, that the real culprit might be the Inquirer package.

@meszaros-lajos-gyorgy
Copy link
Author

Possible related tickets on Inquirer side: SBoudrias/Inquirer.js#667

@meszaros-lajos-gyorgy
Copy link
Author

meszaros-lajos-gyorgy commented Sep 9, 2018

I've just realized, that commitizen uses version 1.2.3 of Inquirer, while the latest version is 6.2.0. 1.2.3 was released on Nov 13, 2016. Might worth trying to update it.

@meszaros-lajos-gyorgy
Copy link
Author

On mac it works fine.

@meszaros-lajos-gyorgy
Copy link
Author

Now the battery on my windows laptop is about to die on low charge and commitizen finished without any issue whatsoever. Is there a race condition somewhere in the code that causes this behavior?

@meszaros-lajos-gyorgy
Copy link
Author

The power is back on and commitizen doesn't halt again.

@meszaros-lajos-gyorgy
Copy link
Author

And now with a shorter commit, it finished correctly...

@jimthedev
Copy link
Member

FYI Inquirer 6 was released in commitizen 3.0.1

@meszaros-lajos-gyorgy
Copy link
Author

Thank you for the information! I'll recheck this as soon as I can and I'll give feedback on whether the issue still present or not.

@jimthedev
Copy link
Member

Cheers.

@meszaros-lajos-gyorgy
Copy link
Author

Updated commitizen to 3.0.2 and all works fine! Closing ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants