Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: process does not terminate after creating a commit with the --re… #974

Closed
wants to merge 2 commits into from

Conversation

coffe0wl
Copy link

@coffe0wl coffe0wl commented Jun 3, 2023

Problem:

The problem appears when the user creates a commit with the --retry option.

When creating a commit without this parameter, the process will be completed by a function that acts as a prompt, since without this parameter this function is not executed because the data is taken from the cache, the process was not completed.

Therefore, a line was added that terminates the process in case there was no error.

@coffe0wl coffe0wl marked this pull request as draft June 7, 2023 07:33
@coffe0wl coffe0wl marked this pull request as ready for review June 7, 2023 07:33
@markovdigital
Copy link

Hi, @jimthedev

Is there any chance this fix will land? The --retry workflow doesn't seem to work without it.

@simplenotezy
Copy link

I am also experiencing --retry not working; is that because of this missing PR?

It just hangs forever:
image

@yrambler2001
Copy link

@simplenotezy

is that because of this missing PR

yes

It just hangs forever

it hangs, you can press ctrl-c to stop the execution, and the commit will be committed.

@jimthedev
Copy link
Member

The CI job for this is long gone so I can't re-run. I am creating an alternative branch and will give it a try.

@jimthedev
Copy link
Member

Mirror PR: #1001

Copy link

🎉 This issue has been resolved in version 4.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jimthedev
Copy link
Member

Let me know if there are other PRs you want prioritized. I can't promise I will get to them all, but we can try :D Also if you can let me know if this worked, I'd appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants