-
Notifications
You must be signed in to change notification settings - Fork 4
Supported Socket.io #51
base: onigo-port
Are you sure you want to change the base?
Supported Socket.io #51
Conversation
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion. js/sphero-client.js, line 2 at r1 (raw file):
S は大文字で、 Comments from Reviewable |
Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions. js/sphero-client.js, line 44 at r1 (raw file):
あ、ここ引数で name 受け取り忘れてた! Comments from Reviewable |
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion. js/sphero-client.js, line 10 at r2 (raw file):
ソースを見る限り this.socket に代入するのは、このすぐ下の new SocketIOClient しかないので、 あと、this.socket がすでに作られている場合、今渡された引数 wsHost と、すでに this.socket がもっている wsHost が異なる場合、どのような挙動をするのが良いでしょうか? Comments from Reviewable |
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion. js/sphero-client.js, line 10 at r2 (raw file):
今現在は既に接続があったら何もしていません サーバーを切り替える、みたいなのがいいと思うんですが、 たぶん上の if 文を消すだけで実装できますw Comments from Reviewable |
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion. js/sphero-client.js, line 10 at r2 (raw file): Previously, shundroid wrote…
あ、それとも Issue にしたほうがいいでしょうか Comments from Reviewable |
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion. js/sphero-client.js, line 10 at r2 (raw file): Previously, shundroid wrote…
了解です。じゃ、console.log かなにかでログだけでも残しておきましょうか。 Comments from Reviewable |
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion. js/sphero-client.js, line 10 at r2 (raw file): Previously, dadaa wrote…
そうします、if 文で return する前に console.log をします @nakamurataichi: お願いします! Comments from Reviewable |
This change is