Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specification of Rhino version during installation #1305

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tomvanmele
Copy link
Member

Attempt to simplify the installation process and return more meaningful error feedback to the user...

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@tomvanmele
Copy link
Member Author

@gonzalocasas @Licini @chenkasirer not sure if you get a notification if i submit as draft...

@gonzalocasas
Copy link
Member

@gonzalocasas @Licini @chenkasirer not sure if you get a notification if i submit as draft...

Yep, got one!

I was thinking about this, would it be possible to install to all available rhinos by default instead of trying to figure out which rhino it is that the user wants? Installing to a single specific one then would be the task of passing the -v ARGS

@tomvanmele
Copy link
Member Author

yes that should be possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants