Add volume subpath option

[vvoland]

• related: Add volume subpath property compose-spec#471

Only supported in the long syntax.

[ndeloof]

that sounds a bit weird to me: if we can detect use of subpath here, why not support this syntax ?

[vvoland]

The reason is to make it consistent with the Docker CLI where we don't support the short syntax, only the long --mount.
We decided to not support it in the short syntax is to avoid growing parsing complexity.

But if compose is fine with that, I'm happy to implement it.

[ndeloof]

right, then maybe better have a generic default case rejecting any unsupported attribute

[vvoland]

The default branch seems to explicitly ignore the unsupported attributes:

compose-go/format/volume.go

Lines 98 to 102 in a1f149a

	default:
	if isBindOption(option) {
	setBindOption(volume, option)
	}
	// ignore unknown options

Also, in this case the option is supported, just not in the short syntax. Returning an "not supported" message could make the user think that it's not supported at all.

[ndeloof]

how does the CLI report attempt to use such an attribute ?

[vvoland]

CLI errors out when an unknown attribute is used in both long and short syntax.

As for the subpath option specifically, it's not handled differently and will error out just the same as an invalid attribute.

$ docker run -v asddd:/v:volume-subpath=sub --rm -it alpine                                                                                                                                                                      
docker: Error response from daemon: invalid mode: volume-subpath=sub.

[ndeloof]

right, then I don't think compose should try to be more clever/friendly here OR subpath should be made an explicit short-syntax feature

[vvoland]

Fair enough. Removed the special case for the short syntax.