-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable ethers logging #257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 Would love for these pesky logs to go away. Though I'm not sure if it will be masking any other warnings that we might care about. Let's see what Jared and Geoff think.
Yeah these logs are super annoying, but seems like we might want some logging at some point? |
@jflatow yeah, we probably do want these logs some of the time. but i've been using this patch locally the last few days and it's been really helpful to actually be able to read the scenario logs maybe we could optionally disable it? |
Yeah what about adding an env var to disable like |
b6439d7
to
b95ff92
Compare
@jflatow I updated this to be a flag on the
if you want to reduce the output. |
This reverts commit 7b4bd0b.
Our scenario output is dominated by
duplicate definition - //...
We can turn that off using
ethers.utils.Logger.setLogLevel
.Not sure if we'd be losing other useful information, but it makes things a lot more readable:
Before:
After:
source: ethers-io/ethers.js#379 (comment)