Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test to ensure that #6288 is reverted in v1.22 #6292

Closed
wants to merge 8 commits into from
Closed

Add a test to ensure that #6288 is reverted in v1.22 #6292

wants to merge 8 commits into from

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Jan 2, 2020

Changelog: omit
Docs: omit

This test ensures that changes introduced in #6288 won't be deployed in Conan v1.22:

  • The test fails with changes introduced in that PR
  • The test fails if the version is >=1.22.0

Rationale: #6269 (comment)

@jgsogo jgsogo added this to the 1.22 milestone Jan 2, 2020
@jgsogo jgsogo mentioned this pull request Jan 2, 2020
Merged
@jgsogo jgsogo self-assigned this Jan 2, 2020
@jgsogo jgsogo mentioned this pull request Jan 28, 2020
Closed
@jgsogo jgsogo closed this Jan 28, 2020
@jgsogo jgsogo deleted the sentinel/cmake-generator branch January 28, 2020 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jgsogo jgsogo

Labels
None yet
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
2 participants
@jgsogo @memsharded