-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding Healey 1970 #1311
adding Healey 1970 #1311
Conversation
@SimonGreenhill I'll moderate the PR after the release. I hope it's okay if we don't include the list in 3.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnnikaTjuka I was just finishing writing my review. So maybe it can stay there until your revision after the release.
Thanks @MuffinLinwist -- most changes made, except for the ones I commented on. |
Thanks, @MuffinLinwist and @SimonGreenhill! Would you have time to do the second review for the list, @Tarotis? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, thanks for adding the list @SimonGreenhill , here are my comments. I have added a couple of suggestions for changes, and also one case where I'd ask for your suggestion @AnnikaTjuka .
@Tarotis I just went through all your comments. I'd generally refrain from changing the glosses if they are in the original list. If we notice a lot of mistakes in a list, we usually add an extra column where we correct the glosses. But it must be transparent that we are making the changes and that they do not correspond to the original list. |
worked through @Tarotis suggestions. |
Thanks, @SimonGreenhill! I'll do a final check later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just three more suggestions but then everything should be ready to be merged. @Tarotis We'll need your approval of the requested changes before merging.
all Annika's changes have been made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks, @SimonGreenhill! Feel free to merge.
thanks Annika, merged. |
Pull request checklist
concepticon notlinked --gloss "NEW_GLOSS"
Additional information
New concept list, scanned list attached here:
Healey1970.pdf