Lai rgalrong #1331
Lai rgalrong #1331
Conversation
|
@MuffinLinwist and @CarolinHu would you be available to review this PR quickly? We would like to resubmit at some point soon, so it would be helpful to have this already covered. We do not expect many problems, since the concept list is mainly based on Sagart's list from 2019. |
Yes! I'll add it as part of the tasks for the next two days.. |
|
@laiyunfan, you can see the current data in EDICOTR with a link that makes it easy to browse the data when using this link: I think we may argue that this is enough for the time being? |
|
I'd then make a version for the current state of the data, and that would be it? |
|
Yes, I think that would be it. Then I will do a final check of the manuscript and the response, and will finally submit it. |
There was a problem hiding this comment.
@LinguList and @laiyunfan, my review of this PR is finished. Just minor comments on some mappings.
| Lai-2023-291-10 158 red 156 RED 1007 red | ||
| Lai-2023-291-11 14 black 163 BLACK 1005 black | ||
| Lai-2023-291-12 16 to blow (of wind) 175 BLOW (OF WIND) 1738 to blow (of wind) | ||
| Lai-2023-291-13 17 the body hair (hair or fur) 189 HAIR (BODY) 266 the body hair (hair or fur) // the hair |
There was a problem hiding this comment.
Perhaps, HAIR OR FUR is better for this one.
There was a problem hiding this comment.
The Chinese concept is maximally unspecified, but in this case, the base list links already to body hair, so we better just follow that mapping.
| Lai-2023-291-53 170 the sand 671 SAND 44 the sand | ||
| Lai-2023-291-54 43 early 672 EARLY 1018 early | ||
| Lai-2023-291-55 134 the mouth 674 MOUTH 84 the mouth | ||
| Lai-2023-291-56 250 the shit 676 SHIT (DEFECATE) 151 the shit |
There was a problem hiding this comment.
The current mapping refers to the action. I believe FAECES (EXCREMENT) would be a more suitable mapping for this gloss.
There was a problem hiding this comment.
Yes, this is a wrong mapping.
| Lai-2023-291-81 161 right 1019 RIGHT 711 right | ||
| Lai-2023-291-82 425 to yawn 1028 YAWN to yawn | ||
| Lai-2023-291-83 76 good 1035 GOOD 1052 good | ||
| Lai-2023-291-84 80 the hair (of the head) 1040 HAIR 75 the hair (of the head) |
There was a problem hiding this comment.
HAIR (HEAD) would be a more suitable mapping.
| Lai-2023-291-84 80 the hair (of the head) 1040 HAIR 75 the hair (of the head) | ||
| Lai-2023-291-85 117 light (of weight) 1052 LIGHT (WEIGHT) 1015 light (of weight) | ||
| Lai-2023-291-86 233 the wheat 1077 WHEAT 410 the wheat | ||
| Lai-2023-291-87 359 the work 1086 WORK (ACTIVITY) the work |
There was a problem hiding this comment.
The current mapping referes to the action. WORK (LABOUR) is a more suitable mapping.
| Lai-2023-291-135 84 the head 1256 HEAD 74 the head | ||
| Lai-2023-291-136 239 the wing 1257 WING 298 the wing | ||
| Lai-2023-291-137 183 to sing 1261 SING 1184 to sing | ||
| Lai-2023-291-138 90 high / tall 1265 HIGH 968 high / tall |
There was a problem hiding this comment.
HIGH OR TALL perhaps is a more suitable mapping.
| Lai-2023-291-141 81 the hand 1277 HAND 107 the hand | ||
| Lai-2023-291-142 227 to vomit 1278 VOMIT 1535 to vomit | ||
| Lai-2023-291-143 379 to fall 1280 FALL to fall | ||
| Lai-2023-291-144 312 the fat (grease) 1282 FAT (FROM ANIMALS) the fat (grease) |
There was a problem hiding this comment.
the fat (grease) has been previously mapped as FAT (ORGANIC SUBSTANCE) in our concept lists.
| Lai-2023-291-182 153 to play 1413 PLAY 1703 to play | ||
| Lai-2023-291-183 414 to squeeze 1414 SQUEEZE to squeeze | ||
| Lai-2023-291-184 213 to think (reflect) 1415 THINK (REFLECT) 1726 to think (reflect) | ||
| Lai-2023-291-185 409 to sit 1416 SIT to sit |
There was a problem hiding this comment.
Entry for HUANG_1992_1820 column is empty. Just to confirm, is this not missing?
There was a problem hiding this comment.
These are new entries. This is correct.
| Lai-2023-291-287 45 the earthworm 2350 EARTHWORM 363 the earthworm | ||
| Lai-2023-291-288 38 the dream 2374 DREAM 699 the dream | ||
| Lai-2023-291-289 93 horizontal 2376 HORIZONTAL 1001 horizontal | ||
| Lai-2023-291-290 430 wide 2531 BROAD wide |
There was a problem hiding this comment.
Perhaps, WIDE or BROAD OR WIDE is a more suitable mapping?
|
Thanks, @MuffinLinwist, good catches, I'll look into those later. |
|
My updates should have addressed these cases now. |
|
I'll thus merge now. I also fixed an error in Huang, which is useful, thanks @MuffinLinwist ! |
|
Thank you very much! |
Pull request checklist
concepticon notlinked --gloss "NEW_GLOSS"Additional information
Concept list must be added for a lexibank dataset, where we currently draft the revision.