Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO MRG: Test building with conda-build 2.0.x and conda 4.2.x #8

Closed
wants to merge 4 commits into from

Conversation

jjhelmus
Copy link

No description provided.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The recipe license should not include the word "License".

Use a channel which has long prefix version of packages which are used in the
build environment so a long prefix build is possible.
@jjhelmus
Copy link
Author

Commit 5960e39 pulls in three packages (ncurses, openssl, and curl) from the jjhelmus/label/bootstrap channel which were copied from the defaults channel and support installation into a long prefix environment. Without these a short (80) character prefix environment is used for the build.

@jakirkham
Copy link
Member

So I'm unclear on if we can tell if that fixes the issue as upgrading to the newer conda seemed to already fix it. Would be worthwhile to drop the conda upgrade and see if that still works?

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jjhelmus
Copy link
Author

So I'm unclear on if we can tell if that fixes the issue as upgrading to the newer conda seemed to already fix it. Would be worthwhile to drop the conda upgrade and see if that still works?

Nope, using conda 4.1.12 results in the cmake: error while loading shared libraries: libarchive.so.13: cannot open shared object file: No such file or directory issue

@jakirkham
Copy link
Member

So it sounds like the fix is just to upgrade conda then and it doesn't matter if we rebuild anything, right?

@jjhelmus
Copy link
Author

jjhelmus commented Nov 11, 2016

So it sounds like the fix is just to upgrade conda then and it doesn't matter if we rebuild anything, right?

That will result in builds which work but produces packages with a short 80 character prefix. It is a step forward but more is needed.

@ocefpaf
Copy link
Member

ocefpaf commented Nov 9, 2017

I think this one is safe to close. Please re-open it I am wrong.

@ocefpaf ocefpaf closed this Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants