Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump upper pin on sphinx to 7.2 #60

Merged
merged 3 commits into from
Aug 18, 2024

Conversation

raybellwaves
Copy link
Member

@raybellwaves raybellwaves commented Jun 3, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Does anyone know why sphinx is constrained to >=4.0,<7.0.0a?

I couldn't see that specified in breath e.g. https://github.com/breathe-doc/breathe/blob/main/setup.py#L20

I came across breathe-doc/breathe#975 so I assume it currently works up to sphinx 7.2.6.

I was curious if bumping the sphinx version in a project will help with a PR i'm working on (https://github.com/rapidsai/cudf/pulls/raybellwaves) but it seems breathe is preventing me from bumping the sphinx version.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@raybellwaves
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@hmaarrfk hmaarrfk added the automerge Merge the PR when CI passes label Aug 18, 2024
@github-actions github-actions bot merged commit 6a35aa7 into conda-forge:main Aug 18, 2024
3 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants