Adds pinnings for ffmpeg, libblitz, libmatio, libsvm, sox, vlfeat. #194

183amir · 2016-07-13T13:07:20Z

For libblitz: http://upstream.rosalinux.ru/versions/blitz.html

For ffmpeg: http://abi-laboratory.pro/tracker/timeline/ffmpeg/

For vlfeat: They keep adding new features in patch version: http://www.vlfeat.org/ and major version is 0. If they are following the semantic versioning schemes: Major version zero (0.y.z) is for initial development. Anything may change at any time. The public API should not be considered stable.. New features will break our packages: conda-forge/staged-recipes#475 but however maybe pinning like >0.9.20 be a better option but since this is version 0 and they don't follow good practices, the safest bet is to pin it on a patch version. They don't release often.

For sox: There is no guarantee that they will not break API: http://upstream.rosalinux.ru/versions/libsox.html

I am guessing API compatibility for libmatio, libsvm.

183amir · 2016-07-13T13:09:00Z

These are the dependencies that I care about and I don't want them to break my packages in future.
There maybe many more packages that we need to pin.

patricksnape · 2016-07-14T20:40:52Z

Why does vlfeat need pinning on a patch version? Do we know they are likely to break backwards compatibility in the future? 0.9.20 came out in Jan 2015.

183amir · 2016-07-15T05:48:20Z

I read their change log and guessed.

183amir · 2016-07-15T08:27:42Z

Also: http://semver.org/#spec-item-4 Major version zero (0.y.z) is for initial development. Anything may change at any time. The public API should not be considered stable.

patricksnape · 2016-07-15T08:29:16Z

True, but that assumes 1) That they are following semver 2) That they would some day move to 1.x

It doesn't quite work if you stay 0.x forever! Still, I admit that they do appear to be making breaking changes on patch versions, so fair enough. Though it hasn't updated in a long time!

183amir · 2016-07-15T08:31:22Z

Yes but also their changelog suggests that they add new features in patch version:

News

14/1/2015 VLFeat 0.9.20 released
    Maintenance release. Bugfixes.
12/9/1014 MatConvNet
    Looking for an easy-to-use package to work with deep convolutional neural networks in MATLAB? Check out our new MatConvNet toolbox!
12/9/2014 VLFeat 0.9.19 released
    Maintenance release. Minor bugfixes and fixes compilation with MATLAB 2014a.
29/01/2014 VLFeat 0.9.18 released
    Several bugfixes. Improved documentation, particularly of the covariant detectors. Minor enhancements of the Fisher vectors. [Details] 
22/06/2013 VLFeat 0.9.17 released
    Rewritten SVM implementation, adding support for SGD and SDCA optimizers and various loss functions (hinge, squared hinge, logistic, etc.) and improving the interface. Added infrastructure to support multi-core computations using OpenMP. Added OpenMP support to KD-trees and KMeans. Added new Gaussian Mixture Models, VLAD encoding, and Fisher Vector encodings (also with OpenMP support). Added LIOP feature descriptors. Added new object category recognition example code, supporting several standard benchmarks off-the-shelf. This is the third point update supported by the PASCAL Harvest programme. [Details] 
01/10/2012 VLBenchmarks 1.0-beta released.
    This new project provides simple to use benchmarking code for feature detectors and descriptors. Its development was supported by the PASCAL Harvest programme. [Details]
01/10/2012 VLFeat 0.9.16 released
    Added VL_COVDET() (covariant feature detector). This function implements the following detectors: DoG, Hessian, Harris Laplace, Hessian Laplace, Multiscale Hessian, Multiscale Harris. It also implements affine adaptation, estimation of feature orientation, computation of descriptors on the affine patches (including raw patches), and sourcing of custom feature frame. Added the auxiliary function VL_PLOTSS(). This is the second point update supported by the PASCAL Harvest programme. [Details]
11/9/2012 VLFeat 0.9.15 released
    Added VL_HOG() (HOG features). Added VL_SVMPEGASOS() and a vastly improved SVM implementation. Added IHASHSUM (hashed counting). Improved INTHIST (integral histogram). Added VL_CUMMAX(). Improved the implementation of VL_ROC() and VL_PR(). Added VL_DET() (Detection Error Trade-off (DET) curves). Improved the verbosity control to AIB. Added support for Xcode 4.3, improved support for past and future Xcode versions. Completed the migration of the old test code in toolbox/test, moving the functionality to the new unit tests toolbox/xtest. Improved credits. This is the first point update supported by the PASCAL Harvest (several more to come shortly). A big thank to our sponsor! [Details]. 
10/1/2012 PASCAL2 Harvest funding
    In the upcoming months many new functionalities will be added to VLFeat thanks to the PASCAL Harvest! See here for details. 


© 2007-13 The authors of VLFeat

patricksnape · 2016-07-15T08:35:58Z

Sure, but new features aren't breaking changes. Only changing previously provided public API behaviour/existence is. Anyway, I agreed with you in that their version system is merely one of their own and so pinning it seems the safest option!

183amir · 2016-07-15T08:41:01Z

New features will break our packages: conda-forge/staged-recipes#475
but however maybe pinning like >0.9.20 be a better option but since this is version 0 and they don't follow good practices I want to be sure.

patricksnape · 2016-07-15T08:50:01Z

As I said, I think pinning this is safe since vlfeat seems to be following no real versioning scheme whatsoever (the first version was 0.9.15?). I 👍 the vlfeat pinning!

jakirkham · 2016-07-17T23:12:35Z

scripts/pin_the_slow_way.py

@@ -31,19 +31,25 @@
 pinned = {
          'boost': 'boost 1.61.*',
          'bzip2': 'bzip2 1.0.*',
+          'ffmpeg': 'ffmpeg 2.8.*',


jakirkham · 2016-07-17T23:16:56Z

Happy with the ffmpeg pinning. The libpng pinning is being addressed in another PR. Not really familiar with the rest so will trust your judgement.

183amir · 2016-07-22T09:32:22Z

LGTM?

jakirkham · 2016-07-27T01:26:39Z

@conda-forge/core, any comments by anyone to these pinnings? It seems we are in agreement. Would it be too extreme to say we should merge this within 24hrs if there are no objections?

patricksnape · 2016-07-27T08:27:22Z

All good from my end.

jjhelmus · 2016-07-27T17:04:50Z

LGTM

183amir · 2016-07-28T12:35:51Z

Could you please merge this then?

183amir · 2016-08-11T17:30:35Z

Although this has been merged, I have not seen the pull requests suggesting these pins on my feedstocks. Am I missing something here? Is our automatic pin process broken still?
ping @conda-forge/core

lvc · 2016-08-12T14:16:02Z

Hello,

Missed libraries have been added to the tracker:

http://abi-laboratory.pro/tracker/timeline/vlfeat/
http://abi-laboratory.pro/tracker/timeline/matio/
http://abi-laboratory.pro/tracker/timeline/libsvm/

jakirkham · 2016-08-12T15:29:30Z

@183amir, could you please open a new issue on this repo with a list of the feedstocks that have not received pinning PRs?

jakirkham · 2016-08-12T15:29:59Z

Thanks @lvc. That's very nice of you.

183amir · 2016-08-14T07:44:44Z

@jakirkham I thought the whole purpose of adding the pinnings here was that they would be fixed automatically. Why do you need a list of repos for these pull requests?

jakirkham · 2016-08-14T08:11:04Z

Because the pinning service is working on repos. So if you are having issues, these are special case failures.

In any event, the real point is that we should no longer be discussing this in a merged PR. This is going to get lost. Please open it in a new issue with this info, @183amir.

183amir · 2016-09-07T10:24:33Z

@lvc could you add giflib(https://sourceforge.net/projects/giflib) to this website: http://abi-laboratory.pro/tracker/ too, please?

lvc · 2016-09-13T14:39:51Z

@183amir,

Done: http://abi-laboratory.pro/tracker/timeline/giflib/

Feel free to add more libraries to the tracker (add an issue to https://github.com/lvc/upstream-tracker/issues). I'm interested to add all "live" and popular libraries.

Thank you.

183amir · 2016-09-14T09:05:06Z

Thank you @lvc

jakirkham · 2017-09-24T03:11:51Z

scripts/pin_the_slow_way.py

          'fontconfig': 'fontconfig 2.11.*',
          'freetype': 'freetype 2.6.*',
          'hdf5': 'hdf5 1.8.17|1.8.17.*',
          'icu': 'icu 56.*',
          'jpeg': 'jpeg 9*',
+          'libblitz': 'libblitz 0.10|0.10.*',
+          'libmatio': 'libmatio 1.5.*',


Looks like libmatio might need to be pinned tighter than 1.5.*.

ref: https://abi-laboratory.pro/tracker/timeline/matio/

jakirkham reviewed Jul 17, 2016
View reviewed changes

Added pinnings for several other packages.

9a7eee7

183amir force-pushed the patch-1 branch from 6d99936 to 9a7eee7 Compare July 22, 2016 09:30

183amir changed the title ~~Added pinnings for several other packages.~~ Adds pinnings for ffmpeg, libblitz, libmatio, libsvm, sox, vlfeat. Jul 22, 2016

patricksnape merged commit 0cce93f into conda-forge:master Jul 28, 2016

183amir mentioned this pull request Aug 14, 2016

Automated Pinning pull requests are not sent #207

Closed

jakirkham reviewed Sep 24, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds pinnings for ffmpeg, libblitz, libmatio, libsvm, sox, vlfeat. #194

Adds pinnings for ffmpeg, libblitz, libmatio, libsvm, sox, vlfeat. #194

183amir commented Jul 13, 2016 •

edited

Loading

183amir commented Jul 13, 2016

patricksnape commented Jul 14, 2016 •

edited

Loading

183amir commented Jul 15, 2016

183amir commented Jul 15, 2016

patricksnape commented Jul 15, 2016 •

edited

Loading

183amir commented Jul 15, 2016 •

edited

Loading

patricksnape commented Jul 15, 2016

183amir commented Jul 15, 2016

patricksnape commented Jul 15, 2016 •

edited

Loading

jakirkham Jul 17, 2016

jakirkham commented Jul 17, 2016

183amir commented Jul 22, 2016

jakirkham commented Jul 27, 2016

patricksnape commented Jul 27, 2016

jjhelmus commented Jul 27, 2016

183amir commented Jul 28, 2016

183amir commented Aug 11, 2016

lvc commented Aug 12, 2016

jakirkham commented Aug 12, 2016

jakirkham commented Aug 12, 2016

183amir commented Aug 14, 2016

jakirkham commented Aug 14, 2016

183amir commented Sep 7, 2016

lvc commented Sep 13, 2016 •

edited

Loading

183amir commented Sep 14, 2016

jakirkham Sep 24, 2017

Adds pinnings for ffmpeg, libblitz, libmatio, libsvm, sox, vlfeat. #194

Adds pinnings for ffmpeg, libblitz, libmatio, libsvm, sox, vlfeat. #194

Conversation

183amir commented Jul 13, 2016 • edited Loading

183amir commented Jul 13, 2016

patricksnape commented Jul 14, 2016 • edited Loading

183amir commented Jul 15, 2016

183amir commented Jul 15, 2016

patricksnape commented Jul 15, 2016 • edited Loading

183amir commented Jul 15, 2016 • edited Loading

patricksnape commented Jul 15, 2016

183amir commented Jul 15, 2016

patricksnape commented Jul 15, 2016 • edited Loading

jakirkham Jul 17, 2016

Choose a reason for hiding this comment

jakirkham commented Jul 17, 2016

183amir commented Jul 22, 2016

jakirkham commented Jul 27, 2016

patricksnape commented Jul 27, 2016

jjhelmus commented Jul 27, 2016

183amir commented Jul 28, 2016

183amir commented Aug 11, 2016

lvc commented Aug 12, 2016

jakirkham commented Aug 12, 2016

jakirkham commented Aug 12, 2016

183amir commented Aug 14, 2016

jakirkham commented Aug 14, 2016

183amir commented Sep 7, 2016

lvc commented Sep 13, 2016 • edited Loading

183amir commented Sep 14, 2016

jakirkham Sep 24, 2017

Choose a reason for hiding this comment

183amir commented Jul 13, 2016 •

edited

Loading

patricksnape commented Jul 14, 2016 •

edited

Loading

patricksnape commented Jul 15, 2016 •

edited

Loading

183amir commented Jul 15, 2016 •

edited

Loading

patricksnape commented Jul 15, 2016 •

edited

Loading

lvc commented Sep 13, 2016 •

edited

Loading