use ruleset to enable branch protections #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should avoid issues with the default branch not existing
1 task
beckermr
requested changes
Oct 8, 2024
|
OK. That's what I started to do, but this pattern is already used a number of times in this file already so I copied what's there. I'll be afk until tonight if you want to take over and finish it before then. |
|
Ok then it doesn't make sense to fix it here. Sigh. Lgtm. |
|
fwiw, I proposed making |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should avoid issues with the default branch not existing, which was required for the
edit_protectionAPI.I believe this is the equivalent ruleset. I've run it against scifem-feedstock, so you can see the resulting rule here.
closes #2080