Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing_extensions runtime dependency to meta.yaml #54

Closed
wants to merge 1 commit into from

Conversation

Michael-J-Ward
Copy link

@Michael-J-Ward Michael-J-Ward commented Sep 18, 2024

This Change

datafusion-python requires the runtime dependency typing_extensions as of v40.

We updated our own conda recipe that we use to build conda nightlies, but I failed to upstream that change here.

I believe the v40.1.0 PR needs to be updated with the change in this PR, then those tests should pass and v41 can be rebased off that change.

ref: apache/datafusion-python#750

Note

If you have any suggestions on keeping these two in line, please let me know. Editing the build file in two places seems non-optimal.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Please add any other relevant info below:

This is required as of `datafusion-python` v40.

ref: apache/datafusion-python#750
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Copy link
Contributor

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andygrove andygrove marked this pull request as ready for review September 19, 2024 13:30
@andygrove andygrove marked this pull request as draft September 19, 2024 13:30
@Michael-J-Ward
Copy link
Author

These changes were incorporated into the v40 PR which then succeeded. #52

v41 was recreated after that and also succeded. #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants