Does eccodes really need perl? #9
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@pelson eccodes has one test, which uses a perl script to compare two result files. If we are sure that this test will actually run OK, than we could just skip this particular test. |
|
Thanks @kmuehlbauer. If it needs it, then we should keep it as a dependency. I'll put forward a PR which fixes the pinning. Thanks, |
|
Let's see how that does. |
| @@ -44,6 +44,9 @@ conda install --yes conda-build | |||
| conda info | |||
|
|
|||
| # Embarking on 1 case(s). | |||
| set -x | |||
| export CONDA_PERL=5.20.3.1 | |||
| set +x | |||
There was a problem hiding this comment.
Do we need the set +/- x here? Or they are debug leftovers?
There was a problem hiding this comment.
This comes out of these lines in conda-smithy. Given it is just setting environment variable maybe these are not needed.
MNT: Re-render the feedstock Merging, as we have green lights in #9.
|
Checks are green. I think we either merge or close. I'm happy either way, but don't want to drag out the PR. Thanks! |
|
We just lost this one under the radar. Thanks from bringing it back. |
I have plenty of those 😄 |
No description provided.