-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Satisfy both conda-forge and defaults channel requirements #9
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
@183amir I'd rather rebuilt anything that is linking to the old I believe that the main issue right now is Qt, right? @msarahan how far are we from having a new |
The problem is that I want to install |
Why did we switch to |
I think this is more constrained by politics than by technical concerns. I think we could have working qt4 and qt5 recipes very soon - certainly by the end of the week. However, I do not feel that the question of hosting recipes that are not (currently) built with CI has been settled. |
Got it. I am 👍 to a semi-obscure 😈 build for |
Why could Qt packages not be added to |
They are in defaults - but not with JPEG 9 support. You either need to build Qt here, or switch to JPEG 9 there. I don't think I have reasonable justification for pushing the latter. |
Agreed. Conda-forge should be providing a |
Personally, I'm still not sold on hosting packages that we are not building with some sort of build bot. I know that there are other community members that feel very strongly about this. So, don't really want to see this proceed without discussing it in a meeting. |
Alright, it seems that moving forward on different |
My opinion is on #9 (comment). Please do not merge this until more members say that are willing to support build matrix for jpeg everywhere or want to work on fixing |
This is not my favorite solution either, but the other two potential resolutions are feeling very controversial right now. However, this feels less controversial. I expect @183amir is only wanting to do this to a few packages (JasPer, OpenCV 2.x, anything else?). If we can live with this sort of thing in a couple of places, it at least let's him go forward with getting something installable in Anaconda. That way we can give the other more controversial suggestions more time to simmer. |
@ocefpaf I don't want to use the |
Also, the |
That kind of beats the purpose of conda-forge. Sorry to heat that.
I understand. I had the same problem with a many updated software added in conda-forge that did not align with What else from defaults to you need with @msarahan do you think it is possible to build
I know. I am working on the |
Also, I asked for patience here. There are any solutions of the kind I need this that will bring headache in the long term. The PR here, for example, needs a linter update and some discussion on opening a precedent to adding another matrix build. That should be discussed in the meeting too! Note that I am waiting for more than a month for the ping: @gillins, @pelson, @msarahan, and @kmuehlbauer here. |
Sure. Between @ccordoba12 and I, we have already built many platforms. Need to check JPEG version on them, though. Would be nice to finalize the staged-recipe PRs to have a solid reference point. We can rebuild these pretty quickly - maybe 1-2 hours apiece? |
What other things an update to jpeg 9 will break for us? |
Us -> Continuum :-) |
Carlos - I don't think anything breaks - just all the packages have to be lined up. So we need a complete set of solutions here, such that nothing in defaults that uses JPEG 8 is installed. Longer-term, we need to add versions to package names and SO names, so that we can have multiple versions installed. We talked about this in this past Friday's meeting. |
That would be awesome! Even better if you could the same @ccordoba12 this hypothetical |
Aside: I am 👍 on having SO names, but did anyone really though about where that will lead us? condaOS 😈, condaDist 😺, or condaApp 🙀 |
We'll try to update to jpeg 9 this week. A Qt4 package based on conda-forge/staged-recipes#706 and built with conda-forge deps will have to wait two or three more weeks, I'm afraid. We're really busy right now trying to move things to Qt5 for Anaconda 4.1 :-) |
Thanks! I thought that the former solution would be harder, but that works too.
Looking forward to it! |
Missed that comment. There are many reasons, but this is the main one. |
If |
Thanks for clarifying. I think I was out when most of this happened. |
Sorry guys, after a bit of chatting we decided to leave the move to Jpeg 9 to be done after Anaconda 4.1. We still have a lot to do for that release :-) |
Understood, thanks for letting us know, @ccordoba12. 😄 |
If that is the case, can we go forward with this pull then? we can revert the matrix once the |
This PR does not defeat that purpose. It will still keep Let me explain my situation a bit more. I have created an environment with |
No description provided.