Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax jupyterlab constraint #7

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

dhirschfeld
Copy link
Member

@dhirschfeld dhirschfeld commented Aug 4, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@dhirschfeld
Copy link
Member Author

IIUC this should be compatible with jupyterlab >=4
jupyterlab-contrib/rise#42

@dhirschfeld
Copy link
Member Author

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/jupyterlab_rise-feedstock/actions/runs/5758837771.

@dhirschfeld
Copy link
Member Author

import: 'jupyterlab_rise'
import: 'jupyterlab_rise'
+ pip check
No broken requirements found.
+ python -m jupyterlab.browser_check --no-chrome-test
0.00s - Debugger warning: It seems that frozen modules are being used, which may
0.00s - make the debugger miss breakpoints. Please pass -Xfrozen_modules=off
0.00s - to python to disable frozen modules.
0.00s - Note: Debugging will proceed. Set PYDEVD_DISABLE_FILE_VALIDATION=1 to disable this validation.
usage: browser_check.py [-h] [--debug] [--show-config] [--show-config-json]
                        [--generate-config] [-y] [--allow-root] [--no-browser]
                        [--autoreload] [--script] [--no-script] [--core-mode]
                        [--dev-mode] [--skip-dev-build] [--watch]
                        [--splice-source] [--expose-app-in-browser]
                        [--extensions-in-dev-mode] [--collaborative]
                        [--log-level ServerApp.log_level]
                        [--config ServerApp.config_file] [--ip ServerApp.ip]
                        [--port ServerApp.port]
                        [--port-retries ServerApp.port_retries]
                        [--sock ServerApp.sock]
                        [--sock-mode ServerApp.sock_mode]
                        [--transport KernelManager.transport]
                        [--keyfile ServerApp.keyfile]
                        [--certfile ServerApp.certfile]
                        [--client-ca ServerApp.client_ca]
                        [--notebook-dir ServerApp.root_dir]
                        [--preferred-dir ServerApp.preferred_dir]
                        [--browser ServerApp.browser]
                        [--pylab ServerApp.pylab]
                        [--gateway-url GatewayClient.url]
                        [--app-dir BrowserApp.app_dir]
                        [extra_args ...]
browser_check.py: error: unrecognized arguments: --no-chrome-test
Tests failed for jupyterlab_rise-0.40.0-pyhd8ed1ab_1.conda - moving package to /home/conda/feedstock_root/build_artifacts/broken
WARNING:conda_build.build:Tests failed for jupyterlab_rise-0.40.0-pyhd8ed1ab_1.conda - moving package to /home/conda/feedstock_root/build_artifacts/broken

@fcollonval
Copy link
Contributor

Thanks a lot @dhirschfeld

@fcollonval fcollonval merged commit 039a234 into conda-forge:main Aug 7, 2023
2 checks passed
@dhirschfeld dhirschfeld deleted the dhirschfeld-patch-1 branch August 7, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants